search

ROCm / MIOpen

AMD's Machine Intelligence Library
https://rocm.docs.amd.com/projects/MIOpen/en/latest/
Other
1.09k stars 230 forks source link

[HotFix] fix MHA build #3333

Closed CAHEK7 closed 1 month ago

CAHEK7 commented 1 month ago

Related to https://github.com/ROCm/MIOpen/pull/3326#discussion_r1810015066 and https://github.com/ROCm/MIOpen/pull/3332/files#diff-67f8008978cd249ea1918c970041f7f5b2efafe089a48705fe1d68fd21cb5cb8

@junliume

CAHEK7 commented 1 month ago

I guess it can be merged when all the build stages have passed. There is no point to wait for the full tests, since there are no MHA-Dropout tests in our testsuite.

junliume commented 1 month ago

Hi @CAHEK7 thanks for the quick patch! It seems that this PR is included as part of #3326 and we can close this one when it is updated with the TIP of develop. Thanks again.

CAHEK7 commented 1 month ago

Hi @CAHEK7 thanks for the quick patch! It seems that this PR is included as part of #3326 and we can close this one when it is updated with the TIP of develop. Thanks again.

Since #3326 has not been merged and that change appeared in #3332 I decided to create a separated PR with minimal changes to cover that particular issue.

I don't mind getting that fix from another PR.