search

ROCm / MITuna

MIT License
7 stars 0 forks source link

load_job fix #905

Closed cderb closed 1 year ago

cderb commented 1 year ago

Fix to load_job for fin_steps arg.

msaudulhassan commented 1 year ago

On https://github.com/ROCmSoftwarePlatform/MITuna/blob/c451c85342b2a2743d9c97bb3796f5ce38f8f02a/tuna/miopen/subcmd/load_job.py#L51, should the check be if args.fin_steps == 'not_fin' ?

cderb commented 1 year ago

On

https://github.com/ROCmSoftwarePlatform/MITuna/blob/c451c85342b2a2743d9c97bb3796f5ce38f8f02a/tuna/miopen/subcmd/load_job.py#L51

, should the check be if args.fin_steps == 'not_fin' ?

not_fin is a valid value for the fin_steps argument. This check is correct, it requires the fin_step input not to be an empty string. Though notable not_fin is now the default in the input parsing.