ROCm / MIVisionX

MIVisionX toolkit is a set of comprehensive computer vision and machine intelligence libraries, utilities, and applications bundled into a single toolkit. AMD MIVisionX also delivers a highly optimized open-source implementation of the Khronos OpenVX™ and OpenVX™ Extensions.
https://rocm.docs.amd.com/projects/MIVisionX/en/latest/
MIT License
184 stars 71 forks source link

[Issue]: Develop - Compile Failure #1367

Closed kiritigowda closed 3 weeks ago

kiritigowda commented 4 weeks ago

Problem Description

Merging #1323 is causing compile failure

[ 97%] Building CXX object amd_openvx_extensions/amd_rpp/CMakeFiles/vx_rpp.dir/source/tensor/Snow.cpp.o
/home/kiriti/develop/mivisionx-kiriti/MIVisionX/amd_openvx_extensions/amd_rpp/source/tensor/Resample.cpp:36:5: error: ‘RpptResamplingWindow’ does not name a type
   36 |     RpptResamplingWindow window;
      |     ^~~~~~~~~~~~~~~~~~~~
/home/kiriti/develop/mivisionx-kiriti/MIVisionX/amd_openvx_extensions/amd_rpp/source/tensor/Resample.cpp:52:27: error: variable or field ‘windowed_sinc’ declared void
   52 | inline void windowed_sinc(RpptResamplingWindow &window, int32_t coeffs, int32_t lobes) {
      |                           ^~~~~~~~~~~~~~~~~~~~
/home/kiriti/develop/mivisionx-kiriti/MIVisionX/amd_openvx_extensions/amd_rpp/source/tensor/Resample.cpp:52:27: error: ‘RpptResamplingWindow’ was not declared in this scope
/home/kiriti/develop/mivisionx-kiriti/MIVisionX/amd_openvx_extensions/amd_rpp/source/tensor/Resample.cpp:52:49: error: ‘window’ was not declared in this scope
   52 | inline void windowed_sinc(RpptResamplingWindow &window, int32_t coeffs, int32_t lobes) {
      |                                                 ^~~~~~
/home/kiriti/develop/mivisionx-kiriti/MIVisionX/amd_openvx_extensions/amd_rpp/source/tensor/Resample.cpp:52:65: error: expected primary-expression before ‘coeffs’
   52 | inline void windowed_sinc(RpptResamplingWindow &window, int32_t coeffs, int32_t lobes) {
      |                                                                 ^~~~~~
/home/kiriti/develop/mivisionx-kiriti/MIVisionX/amd_openvx_extensions/amd_rpp/source/tensor/Resample.cpp:52:81: error: expected primary-expression before ‘lobes’
   52 | inline void windowed_sinc(RpptResamplingWindow &window, int32_t coeffs, int32_t lobes) {
      |                                                                                 ^~~~~
/home/kiriti/develop/mivisionx-kiriti/MIVisionX/amd_openvx_extensions/amd_rpp/source/tensor/Resample.cpp: In function ‘vx_status initializeResample(vx_node, _vx_reference* const*, vx_uint32)’:
/home/kiriti/develop/mivisionx-kiriti/MIVisionX/amd_openvx_extensions/amd_rpp/source/tensor/Resample.cpp:200:29: error: ‘struct ResampleLocalData’ has no member named ‘window’
  200 |         windowed_sinc(data->window, lookupSize, lobes);
      |                             ^~~~~~
/home/kiriti/develop/mivisionx-kiriti/MIVisionX/amd_openvx_extensions/amd_rpp/source/tensor/Resample.cpp:200:9: error: ‘windowed_sinc’ was not declared in this scope
  200 |         windowed_sinc(data->window, lookupSize, lobes);
      |         ^~~~~~~~~~~~~
make[2]: *** [amd_openvx_extensions/amd_rpp/CMakeFiles/vx_rpp.dir/build.make:1454: amd_openvx_extensions/amd_rpp/CMakeFiles/vx_rpp.dir/source/tensor/Resample.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:1402: amd_openvx_extensions/amd_rpp/CMakeFiles/vx_rpp.dir/all] Error 2
make: *** [Makefile:163: all] Error 2

Operating System

Ubuntu 22.04

CPU

ALL

GPU

AMD Instinct MI300

Other

No response

ROCm Version

ROCm 6.0.0

ROCm Component

MIVisionX

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

rrawther commented 3 weeks ago

Fixed with PR1369