ROCm / MIVisionX

MIVisionX toolkit is a set of comprehensive computer vision and machine intelligence libraries, utilities, and applications bundled into a single toolkit. AMD MIVisionX also delivers a highly optimized open-source implementation of the Khronos OpenVX™ and OpenVX™ Extensions.

https://rocm.docs.amd.com/projects/MIVisionX/en/latest/

MIT License

186 stars 73 forks source link

MIVisionX - OpenVX 1.3 Support #233

Closed kiritigowda closed 3 years ago

kiritigowda commented 4 years ago

OpenVX 1.3

Vision Conformance Profile

[x] - CPU Flow
[x] - GPU - OpenCL Flow
[x] - GPU - HIP Flow

Neural Net Conformance Profile

Missing functions in the implementation

[ ] - vxRegisterUserStructWithName
[ ] - vxGetUserStructNameByEnum
[ ] - vxGetUserStructEnumByName
[ ] - vxQueryMetaFormatAttribute

kiritigowda commented 4 years ago

232 will add support to VX Vision Conformance

kiritigowda commented 4 years ago

372 for Vision Conformance Profile

kiritigowda commented 3 years ago

@paveltc

[x] RunVX support for 1.3 branch merging to master

kiritigowda commented 3 years ago

@paveltc any updates on RunVX support for threshold?

paveltc commented 3 years ago

@kiritigowda not yet. I need to take another look at it and possibly discuss it with you.

kiritigowda commented 3 years ago

OpenVX CPU - Vision Feature Set Full Support
- @paveltc can you benchmark these nodes with 1080P- Nodes List
- Conformance run - AGO_DEFAULT_TARGET=CPU LD_LIBRARY_PATH=./lib ./bin/vx_test_conformance
OpenVX GPU - OpenCL Vision Feature Set
- Conformance run - AGO_DEFAULT_TARGET=GPU LD_LIBRARY_PATH=./lib ./bin/vx_test_conformance --filter=-HarrisCorners.*:-*.ReplicateNode:-*.ImageContainmentRelationship:-*.OnRandomAndNatural:-*.vxWeightedAverage:-vxCanny.*:-*.MapRandomRemap:*.*
OpenVX GPU - HIP Vision Feature Set
- Conformance run - @asalmanp can you put the passing run filter here

AryanSalmanpour commented 3 years ago

@kiritigowda this the passing run filter for HIP backend

LD_LIBRARY_PATH=./lib ./bin/vx_test_conformance --filter=-.VirtualArray:-FastCorners.:-HarrisCorners.:-vxCanny.:-.ReplicateNode:-.ImageContainmentRelationship:-.GraphState:-.MapRandomRemap:-.OnRandomAndNatural:-.vxWeightedAverage:-Scale.GraphProcessing:-WarpPerspective.GraphProcessing:-Remap.GraphProcessing:-GaussianPyramid.GraphProcessing:-HalfScaleGaussian.GraphProcessing:.

kiritigowda commented 3 years ago

@asalmanp can you give me the missing lib needed to build HIP conformance?

cmake -DOPENVX_INCLUDES=\$OPENVX_INC/include -DOPENVX_LIBRARIES=\$OPENVX_DIR/lib/libopenvx.so\\;\$OPENVX_DIR/lib/libvxu.so\\;pthread\\;dl\\;m\\;rt -DOPENVX_CONFORMANCE_VISION=ON ../OpenVX-cts

AryanSalmanpour commented 3 years ago

@kiritigowda please see below. libopenvx_hip.so and libamdhip64.so are required libs for building HIP conformance.

cmake -DCMAKE_BUILD_TYPE=Debug -DOPENVX_INCLUDES=$OPENVX_INC/include -DOPENVX_LIBRARIES=$OPENVX_DIR/lib/libopenvx.so\;$OPENVX_DIR/lib/libopenvx_hip.so\;/opt/rocm/hip/lib/libamdhip64.so\;pthread\;dl\;m\;rt -DOPENVX_CONFORMANCE_VISION=ON ../OpenVX-cts

kiritigowda commented 3 years ago

@asalmanp thanks! Verify #485

kiritigowda commented 3 years ago

OpenVX 1.3 CPU/GPU - OpenCL/HIP support added to TOT. New Issue to track conformance to be Opened.