ROCm / MIVisionX

MIVisionX toolkit is a set of comprehensive computer vision and machine intelligence libraries, utilities, and applications bundled into a single toolkit. AMD MIVisionX also delivers a highly optimized open-source implementation of the Khronos OpenVX™ and OpenVX™ Extensions.
https://rocm.docs.amd.com/projects/MIVisionX/en/latest/
MIT License
186 stars 74 forks source link

graph.nnef Parse error #8

Closed srohit0 closed 5 years ago

srohit0 commented 5 years ago

Using latest amdovx-modules repo to convert nnef to openvx gives me this error

OK: parsing /home/amd/models/nnef/object_detection//mobilenet_v1_1/graph.nnef ... Parse error: [2:12] expected token 'graph', found ';'

NNEF model excerpt


 version 1.0;

 graph mobilenet_v1_1( input ) -> ( output )
 {

Script

MODEL=mobilenet_v1_1
IN_DIR=/home/amd/models/nnef/object_detection/
OUT_DIR=/home/amd/models/openvx/object_detection/

mkdir ${OUT_DIR}/$MODEL
nnef2openvx ${IN_DIR}/$MODEL ${OUT_DIR}/$MODEL

Output

OK: parsing /home/amd/models/nnef/object_detection//mobilenet_v1_1/graph.nnef ... Parse error: [2:12] expected token 'graph', found ';'

NNEF specification

Section 3.2.4 of NNEF Specification Version 1.0, Revision 3, 2018-06-13 states that semicolon ; is part of version statement. Here is excerpt from the specification:

The version info is introduced by the version keyword, and is defined by a real-number numeric literal as major and minor versions separated by a dot:

\ ::= "version" \ ";"

Fix is needed to support NNEF Specification Version 1.0, Revision 3, 2018-06-13

hansely commented 5 years ago

This issue will be resolved after the nnir_to_nnef.py fix pull request.

kiritigowda commented 5 years ago

@hansely is this issue fixed?

kiritigowda commented 5 years ago

refer to issue #54