Use proper notation for temperature and frequency units

ROCm / ROC-smi

ROC System Management Interface

https://github.com/RadeonOpenCompute/ROC-smi/blob/master/README.md

177 stars 56 forks source link

Use proper notation for temperature and frequency units #71

Closed sarunasb closed 5 years ago

sarunasb commented 5 years ago

Please use proper SI/scientific notation for: 1) temperature degrees: °C, not lowercase c; 2) frequency in Hz: MHz, not Mhz.

kentrussell commented 5 years ago

That's a kernel issue, not an SMI issue: https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/blob/master/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c#L4444

However, for degrees, I have cleaned that up internally (to be in 2.8). I'll see if I can get the cleanup for the kernel done as well, or get it assigned to someone who can.