search

ROCm / ROCT-Thunk-Interface

ROCm's Thunk Interface
Other
83 stars 71 forks source link

Mismatch between project version and SOVERSION #62

Closed rigtorp closed 2 months ago

rigtorp commented 4 years ago

Project version is defined in CMakeLists.txt:

project ( ${HSAKMT_TARGET} VERSION 1.9.0)

But later it's not used for the library version (VERSION and SOVERSION):

set ( LIB_VERSION_MAJOR 1)
set ( LIB_VERSION_MINOR 0)
if (${ROCM_PATCH_VERSION})
    set ( LIB_VERSION_PATCH ${ROCM_PATCH_VERSION} )
else ()
    set ( LIB_VERSION_PATCH 6)
endif ()

Instead the CMAKE_PROJECT_VERSION, CMAKE_PROJECT_VERSION_MAJOR, etc variables can be used: https://cmake.org/cmake/help/latest/variable/CMAKE_PROJECT_VERSION.html

Additionally these version numbers do not change between releases. What version should be used when packaging? Fedora for example uses 1.0.6: https://src.fedoraproject.org/rpms/hsakmt/blob/master/f/hsakmt.spec

ppanchad-amd commented 3 months ago

@rigtorp Apologies for the lack of response. Can you please check if your issue still exists with the latest ROCm 6.1.3? If not, please close the ticket. Thanks!

kentrussell commented 2 months ago

We've moved to using a static thunk, so this isn't being actively supported. Thanks for your inquiry.