search

ROCm / ROCm-CompilerSupport

The compiler support repository provides various Lightning Compiler related services.
47 stars 31 forks source link

Add support of compiling HIP to fatbin by hipcc --genco #11

Closed yxsamliu closed 4 years ago

yxsamliu commented 5 years ago

Revised by Scott's comments.

b-sumner commented 4 years ago

I think it is highly undesirable for a JIT to fork/exec and we have worked hard to avoid that for OpenCL compilation. If there is not a pending emergency, let's handle this properly.

yxsamliu commented 4 years ago

I think it is highly undesirable for a JIT to fork/exec and we have worked hard to avoid that for OpenCL compilation. If there is not a pending emergency, let's handle this properly.

As discussed, in-process-compilation is not an imminent feature for HIP. In the first stage it will be out of process.

yxsamliu commented 4 years ago

Updated the PR to let the caller specify hipcc path through compilation options. This is because there are situations where environment variable cannot be used to find the path to hipcc.