ROCm / ROCm-CompilerSupport

The compiler support repository provides various Lightning Compiler related services.
45 stars 31 forks source link

Comgr should allow dynamic linking of clang libs #40

Closed Mystro256 closed 2 years ago

Mystro256 commented 2 years ago

Fedora doesn't provide static builds of clang, and discourages the use of static libs.

Can we add logic to allow dynamically linking against clang?

The following patch works on Fedora's clang, but probably breaks static linking:

diff --git a/lib/comgr/CMakeLists.txt b/lib/comgr/CMakeLists.txt
index f31bdeb..abdb292 100644
--- a/lib/comgr/CMakeLists.txt
+++ b/lib/comgr/CMakeLists.txt
@@ -277,7 +277,8 @@ install(FILES
   DESTINATION "${AMD_COMGR_PACKAGE_PREFIX}")

 set(CLANG_LIBS
-  clangFrontendTool)
+  clang
+  clang-cpp)

 set(LLD_LIBS
   lldELF

I expect the correct way of doing this is checking if clangFrontendTool exists (static lib exists), if not, fall back to clang-cpp/clang (dynamic).

Mystro256 commented 2 years ago

fixed in 5495595234e8fb7b1715429cfa41fe6d9c0e710c