search

ROCm / ROCm-ComputeABI-Doc

ROCm - AMDGPU Compute Application Binary Interface
https://github.com/RadeonOpenCompute/ROCm-Docs/blob/master/AMDGPU-ABI.md
40 stars 12 forks source link

amd_compute_pgm_rsrc2_t inconsistent names #6

Closed almson closed 8 years ago

almson commented 8 years ago

Fields such as enable_sgpr_workgroup_id_x and enable_sgpr_workgroup_info have different names in the LLVM assembler. (compute_pgm_rsrc2_tgid_x_en and compute_pgm_rsrc2_tg_size_en respectively.) Please make the ABI doc and the assembler consistent with eachother.

nhaustov commented 8 years ago

LLVM assembler needs to be updated to use names defined in ABI doc.

gstoner commented 8 years ago

Thank you for reporting this. We recently made changes to this document on the direction we are going to set compute capability not using codenames. The team is in the process of updating the assembler to support this capability as specified. Here the Documentation is leading implementation of functionality, it not self-consistancy issue as you have report it.

On Aug 28, 2016, at 9:28 AM, Nikolay Haustov notifications@github.com<mailto:notifications@github.com> wrote:

LLVM assembler needs to be updated to use names defined in ABI doc.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/RadeonOpenCompute/ROCm-ComputeABI-Doc/issues/6#issuecomment-242977841, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD8DuT7ffyLzueKNM43vo8uslRPvXyPFks5qkZsMgaJpZM4Ju3v4.

vpykhtin commented 8 years ago

The change has been submitted by Sam Kolton to the llvm trunk: https://reviews.llvm.org/D24296