search

ROCm / ROCm-Device-Libs

ROCm Device Libraries
97 stars 60 forks source link

mulF.cl implemented x + y #98

Closed TBodyAltra closed 5 months ago

TBodyAltra commented 1 year ago

If you look into mulF.cl carefully, you will notice:

include "mathF.h"

CONSTATTR float MATH_MANGLE(mul_rte)(float x, float y) { return x + y; }

b-sumner commented 1 year ago

Good grief! Thanks for pointing this out, and apologies for any headaches it caused. Will fix ASAP.

b-sumner commented 1 year ago

Fix will not be in ROCm 5.7.

TBodyAltra commented 1 year ago

Wondering do you guys have any test for ocml functions? This typo is so apparent. I want to test too.

TBodyAltra commented 1 year ago

@b-sumner thanks

lamb-j commented 5 months ago

Fixed here:

https://github.com/ROCm/llvm-project/commit/8efb5d685b7cbad40dfb8c73745301b0348a9d95