search

ROCm / ROCm-OpenCL-Runtime

ROCm OpenOpenCL Runtime
170 stars 60 forks source link

Please fix CRLF in opencl/tests/ocltst/module/perf/oclperf.exclude #140

Open Maxzor opened 2 years ago

Maxzor commented 2 years ago

Can you please replace by LF? Dealing with gitconfig autocrlf shenanigans is a pain for some people using git.

Maxzor commented 2 years ago

To be clearer on this topic:

you have released 4.5.2 probably from a windows system, and this file is CRLF in the release tarball, it is maybe crlf in the index and the workdir of the system of the individual whom pushed to this tree. https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime/archive/refs/tags/rocm-4.5.2.tar.gz

The easiest solution is to take care when releasing to not have crlf files. left in your workdir nor your index, with for example:

git ls-files --eol | grep crlf

Which in my case gives i/lf w/crlf attr/-text opencl/tests/ocltst/module/perf/oclperf.exclude

Maxzor commented 2 years ago

I worked around the issue by adding tests/ocltst/module/perf/oclperf.exclude -text -eol to the .gitattributes file, and by running unix2dos on the file...

cgmb commented 2 years ago

I've submitted a fix for this. I'm not an expert on the OpenCL development model, but I believe it is on track for ROCm 5.3.

cgmb commented 2 years ago

@Maxzor, 4b579bf25a0e7e0262f2836d03720a974bd2e866 is now on the develop branch.