search

ROCm / ROCm-OpenCL-Runtime

ROCm OpenOpenCL Runtime
168 stars 55 forks source link

duplicate LICENSE files in khronos/icd/ and khronos/headers/opencl2.2/ #147

Open emollier opened 2 years ago

emollier commented 2 years ago

Hello,

While doing a copyright review for inclusion of rocm-hipamd and dependencies into debian, I noticed some duplicate files LICENSE and LICENSE.txt at the following locations:

On the opencl2.2/ side, timestamps seem to indicate it is LICENSE.txt which applies, but on the icd/ side the situation looks a bit more confusing. LICENSE.txt contains the Khronos group licensing terms, but LICENSE contains the Apache 2.0 license. Skimming through the various files of the icd/ subdirectory I'm temped to assume it is the Apache 2.0 license which applies, but for the few files which do not embed their own terms (some CMakeFiles or some unit tests), the situation is a bit unclear.

Would it be possible to sched some light on the applicable terms of these directories?

Thank you for having made the ROCm OpenCL Runtime publicly available.

Have a nice day, :)\ Étienne.

Mystro256 commented 2 years ago

As far as I know, headers/opencl2.2 is a snapshot of this: https://github.com/KhronosGroup/OpenCL-Headers (Apache-2.0 with some MIT, the latest upstream headers might have been completely relicensed to apache)

While ICD is a snapshot of: https://github.com/KhronosGroup/OpenCL-ICD-Loader (Apache-2.0 license)

It does seem like better documentation would help this.

emollier commented 2 years ago

Hi Jeremy,

Jeremy Newton, on 2022-06-29:

As far as I know, headers/opencl2.2 is a snapshot of this: https://github.com/KhronosGroup/OpenCL-Headers (Apache-2.0 with some MIT, the latest upstream headers might have been completely relicensed to apache)

Okay, for what it's worth, the copy in rocm-opencl-runtime is still mostly under Khronos Group terms (MIT), at the exception of khronos/headers/opencl2.2/tests/*, which are Apache 2.0. Files were probably caught in the middle of the transition I suppose.

git log -- LICENSE.txt doesn't raise anything in upstream OpenCL-Headers. Actually, I can't find any reference to the copyright "2016" LICENSE.txt file in the upstream OpenCL-Headers repository. I thus suppose the LICENSE file with copyright "2008-2015" is the one which should apply for the present copy. Note this is only my own judgement here, and I am not a lawyer. :)

While ICD is a snapshot of: https://github.com/KhronosGroup/OpenCL-ICD-Loader (Apache-2.0 license)

This repository looks like it used to have a LICENSE.txt:

$ cd OpenCL-ICD-Loader/
$ git log -- LICENSE.txt | head
commit bee421e1b9805437d033b06029e83dde48e2e1fc
Author: Khronos Group Webmaster ***@***.***>
Date:   Wed Feb 20 11:01:00 2019 -0500

    Delete LICENSE.txt

A git show bee421 reveals the former terms of Khronos Group. This is consistent with what I see in the rocm-hipamd repository and suppose it is some kind of leftover from several subsequent recursive copies.

If I understood correctly, the Apache 2.0 license applies then.

Thank you for your help!

Have a nice day, :) -- Étienne Mollier @.***> Fingerprint: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da Sent from /dev/pts/2, please excuse my verbosity. On air: J.A.M. - The Usual Unusual

cgmb commented 1 year ago

Does ed25a0b570b6cabe06ae97b4f16edf943d96d540 help?

emollier commented 1 year ago

It definitly makes things less ambiguous, yes. Thanks for the pointer!