search

ROCm / Tensile

Stretching GPU performance for GEMMs and tensor contractions.
MIT License
208 stars 142 forks source link

Removes deprecated package-library option #1940

Closed ellosel closed 2 months ago

ellosel commented 2 months ago

Based on the following comment from #1477:

Some of this functionality is similar to the PackageLibrary option which I notice hasn't been updated in a while and is listed for possible deprecation. When using the PackageLibrary option, TensileCreateLibrary fails to build. I've put my changes alongside this option, although some of the functionality is the same.

and the fact that the --package-library option does not appear to work, this PR removes the option and all associated logic.

ellosel commented 2 months ago

Straightforward PR, looks good. The only consideration I have is how existing YAML configs that contain "PackageLibrary" will respond to this change. My expectation is that it will be a silent parameter in these files. We may want to consider adding some sort of parameter deprecation warning in the future.

Assuming that such a config file exists, that wouldn't be an unreasonable thing to do. I didn't find any config files in Tensile that use PackageLibrary as a key.