search

ROCm / Tensile

Stretching GPU performance for GEMMs and tensor contractions.
MIT License
213 stars 145 forks source link

Remove OCL backend #2008

Closed pghysels closed 2 weeks ago

pghysels commented 1 month ago

resolves #840

Summary:

Remove the OCL backend, which no longer works, and can probably not be made to work anymore.

nakajee commented 1 month ago

I found "Ocl" in .jenkins/common.groovy. Probably better to update it as well.

nakajee commented 1 month ago

maybe better to grep "OpenCL" as well as "ocl" I found the following line in Signature.py. kStr += " .language: %s%s" % ("OpenCL C", writer.endLine) I am not sure if we need to change this or not.

pghysels commented 1 month ago

Sorry, I thought I did grep for both "ocl" and "opencl", case insensitive.

nakajee commented 1 month ago

OK. Thanks for your update. I would like to wait for comments from @AlexBrownAMD

pghysels commented 3 weeks ago

One of these tests is still pending, is there anything I need to do here? I can't tell from the testing details what is wrong.

AlexBrownAMD commented 3 weeks ago

CI didn't have any log files so not sure if they were deleted or the tests didn't run. I just kicked off a rebuild so we can check back in a bit

AlexBrownAMD commented 3 weeks ago

Looks like the only failing pipeline is for gfx1151, and the PR to enable 1151 support just got merged. So you could pull latest changes to your branch and rerun CI to make sure those tests pass as well, otherwise I think this change is safe to merge.

pghysels commented 3 weeks ago

It says I'm not authorized to merge this PR.