ROCm / aotriton

Ahead of Time (AOT) Triton Math Library
MIT License
32 stars 13 forks source link

[Issue]: Unable to build, Unknown CMake command "pybind11_add_module" #28

Open RandUser123sa opened 3 months ago

RandUser123sa commented 3 months ago

Problem Description

Hi,

unable to build the project. I download last release and following documentation do:

mkdir build && cd build cmake .. -DCMAKE_INSTALL_PREFIX=./install_dir -DCMAKE_BUILD_TYPE=Release

I receive the error:

cmake .. -DCMAKE_INSTALL_PREFIX=./install_dir -DCMAKE_BUILD_TYPE=Release

-- The CXX compiler identification is GNU 14.1.0 -- The C compiler identification is GNU 14.1.0 -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: /usr/bin/cc - skipped -- Detecting C compile features -- Detecting C compile features - done CMake Error at CMakeLists.txt:8 (add_subdirectory): The source directory

/root/tour/trit/aotriton-0.5b/third_party/pybind11

does not contain a CMakeLists.txt file.

-- Found Python3: /root/newt/bin/python3.11 (found version "3.11.9") found components: Interpreter -- Performing Test CMAKE_HAVE_LIBC_PTHREAD -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success -- Found Threads: TRUE CMake Error at CMakeLists.txt:46 (get_property): get_property could not find TARGET zstd::libzstd_static. Perhaps it has not yet been created.

-- ZSTD_TARGET zstd::libzstd_static -- get_property AOTRITON_ZSTD_INCLUDE VENV_SITE /root/.local/lib/python3.11/site-packages

CMAKE_SOURCE_DIR /root/tour/trit/aotriton-0.5b CMAKE_CURRENT_LIST_DIR /root/tour/trit/aotriton-0.5b/v2src CMAKE_CURRENT_BINARY_DIR /root/tour/trit/aotriton-0.5b/build/v2src -- AOTRITON_ZSTD_INCLUDE -- AOTRITON_SHIM_FLAGS --archive_only; -- AOTRITON_EXTRA_COMPILER_OPTIONS -I/opt/rocm/include/ -O3 -DNDEBUG CMAKE_INSTALL_INCLUDEDIR include CMake Error at bindings/CMakeLists.txt:6 (pybind11_add_module): Unknown CMake command "pybind11_add_module".

-- Configuring incomplete, errors occurred!

Any suggestion ?

Thanks

Operating System

Slackware 15.0

CPU

AMD Ryzen 7 3800X 8-Core Processor

GPU

AMD Radeon RX 7900 XTX

ROCm Version

ROCm 6.1.0

ROCm Component

No response

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

xinyazhang commented 3 months ago

Oh, you need to clone the repo recursively. If you have already cloned one, use the following command to update all submodules.

git submodule sync
git submodule update --init --recursive --force

Another thing you need to be aware of is, AOTriton does not support Navi GPUs for now. You need an CDNA2/3 GPU to run it.

lhl commented 3 weeks ago

@xinyazhang hi, ran into the issue trying to build today - would you mind updating the README or would you rather a PR?

xinyazhang commented 3 weeks ago

@xinyazhang hi, ran into the issue trying to build today - would you mind updating the README or would you rather a PR?

Can you confirm the command above works? Otherwise we are not confident this is the proper fix to include into the README.md.

Also It's much appreciated if you can file a PR (to main branch) since the the main branch is locked and requires reviews (as owner technically I can bypass this but I don't want to be the sole exception)

RandUser123sa commented 3 weeks ago

Probably will work if some one use GIT version, but still does not compile if I download the Release version. I tested on latest aotriton-0.7preview2 downloaded from here: https://github.com/ROCm/aotriton/releases

-- Detecting C compile features - done
CMake Error at CMakeLists.txt:8 (add_subdirectory):
  The source directory

    /root/tour/trit/aotriton-0.7preview2/third_party/pybind11

  does not contain a CMakeLists.txt file.

-- Found Python3: /usr/bin/python3.11 (found version "3.11.9") found components: Interpreter

and bellow is the error:

tride_rz', 'stride_rm'}): ['u64:16']}
self.FEAT_CHOICES={frozenset({'stride_rn'}): [1]}
For kernel flash.bwd_preprocess, Architecture gfx90a was not found in tuning database, using dummy one instead
For kernel flash.bwd_preprocess, Architecture gfx942 was not found in tuning database, using dummy one instead
For kernel flash.bwd_preprocess, Architecture gfx1100 was not found in tuning database, using dummy one instead
For kernel flash.bwd_preprocess_varlen, Architecture gfx90a was not found in tuning database, using dummy one instead
For kernel flash.bwd_preprocess_varlen, Architecture gfx942 was not found in tuning database, using dummy one instead
For kernel flash.bwd_preprocess_varlen, Architecture gfx1100 was not found in tuning database, using dummy one instead
For kernel flash.debug_fill_dropout_rng, Architecture gfx90a was not found in tuning database, using dummy one instead
For kernel flash.debug_fill_dropout_rng, Architecture gfx942 was not found in tuning database, using dummy one instead
For kernel flash.debug_fill_dropout_rng, Architecture gfx1100 was not found in tuning database, using dummy one instead
Skip rpath=PosixPath('template/autotune_table_entry.cc')
Skip rpath=PosixPath('template/shim.cc')
CMAKE_INSTALL_INCLUDEDIR include
CMake Error at bindings/CMakeLists.txt:6 (pybind11_add_module):
  Unknown CMake command "pybind11_add_module".

-- Configuring incomplete, errors occurred!