Closed pruthvistony closed 1 year ago
LGTM, although I think we should provide an updated method to build without cloning as well. Maybe have that in a different PR to allow this PR to be merged and unblock the JIRAs.
The method of using pyproject.toml is relatively new and there are lot of discussions and usage confusions.
Currently this change is safer since the pyproject.toml (pip install)
method is used only when pip version >=23.1 and for older pip version use the legacy method through setup.py install
.