search

ROCm / clr

MIT License
85 stars 35 forks source link

FindHIP should be installed to ${CMAKE_ROOT}/Modules #29

Closed littlewu2508 closed 7 months ago

littlewu2508 commented 7 months ago

FindHIP.cmake is used in module mode in cmake, and modules should be placed in default location, ${CMAKE_ROOT}/Modules, so cmake can find it by default without appending CMAKE_MODULE_PATH. This is useful for distro installation.

Reference: https://cmake.org/cmake/help/latest/command/find_package.html#search-modes Reference: https://cmake.org/cmake/help/latest/variable/CMAKE_ROOT.html

iassiour commented 7 months ago

Hi @littlewu2508 the FindModule.cmake files under ${CMAKE_ROOT}/Modules are part of cmake repo: https://gitlab.kitware.com/cmake/cmake/-/tree/master/Modules?ref_type=heads and are managed by cmake so I do not think we should change the hip scripts to install the FindHIP.cmake in that location directly. I am closing this PR. However, we can consider moving the FindHIP.cmake to upstream cmake under Modules. Let me followup on this.