search

ROCm / clr

MIT License
85 stars 35 forks source link

The calls to currentStackInfo cause issues if a library uses stackful coroutines #36

Open gbaraldi opened 7 months ago

gbaraldi commented 7 months ago

So the context here is https://github.com/JuliaGPU/AMDGPU.jl/issues/549 where julia switches the thread stack in to have goroutine like tasks. But that causes some issues, specifically in the call to https://github.com/ROCm-Developer-Tools/clr/blob/1a0c3e4dc45237716c08a6b74be5ff6405422ead/rocclr/os/os_posix.cpp#L290-L312 from https://github.com/ROCm-Developer-Tools/clr/blob/d96481fb3609720058180ca5aa02b1da57df68a5/rocclr/thread/thread.cpp#L32-L36 . Taking a quick look, it doesn't seem that the stackBase_ and stackSize_ fields are used anywhere in the library, so I was curious if they have any use, or if they could be removed in order to avoid issues like these

pxl-th commented 4 months ago

Can someone confirm if these can be safely removed?