LWPDCGSS-2256 - Improve library detection

ROCm / clr

MIT License

85 stars 35 forks source link

LWPDCGSS-2256 - Improve library detection #62

Closed paubauer closed 1 week ago

paubauer commented 4 months ago

Add HINTS to find_dependency calls to ensure find_package(HIP) works without having to set ROCM_PATH or CMAKE_PREFIX_PATH externally.

With this change, having find_package(HIP CONFIG PATHS $ENV{ROCM_PATH} "/opt/rocm") will properly detect the additional libaries. Without it, CMAKE_PREFIX_PATH has to be set to /opt/rocm to be able to configure

iassiour commented 1 week ago

Thank you @paubauer for raising this. The changes have now landed on develop branch with this commit: https://github.com/ROCm/clr/commit/eab20385608d16f5a324ba369994ea2258af5de0 I am closing this PR.