search

ROCm / clr

MIT License
85 stars 35 forks source link

Respect CMAKE_PLATFORM_NO_VERSIONED_SONAME when installing libraries. #65

Open stellaraccident opened 3 months ago

stellaraccident commented 3 months ago

Respect CMAKE_PLATFORM_NO_VERSIONED_SONAME when installing libraries.

This is not the best fix because it is manually installing platform specific shared library names/symlinks. However, I don't wish to be on the hook for validating historical practices without a public CI. A better approach would be to install the CMake targets and let CMake do the right thing.

mangupta commented 3 months ago

@stellaraccident : Thanks for submitting the patch for review. Can you please rebase this patch on top of current develop branch? I see too many unrelated commits/files modified as well as merge conflicts for this patch. It would make it harder to review it.