search

ROCm / clr

MIT License
85 stars 35 forks source link

Revert "SWDEV-301667 - Increase default signal pool to 4096" #70

Closed preda closed 3 months ago

preda commented 3 months ago

This reverts commit 94c7004df87cce4b6b0902b365a96905140312f0.

The reason for revert is: the original change introduces a bug in OpenCL when more than one command queue is created: https://github.com/ROCm/ROCR-Runtime/issues/186

Also, in the orignal commit no reason for the change is provided.

In addition to that, 4096 is a particularly bad value (too large) as by default the kernel can only provide 4094 events for DGPUs.

preda commented 3 months ago

Applied as part of https://github.com/ROCm/clr/commit/c157bfb2022076959c521269b27f34996c1ee730