ROCm / clr

MIT License
89 stars 46 forks source link

Add flag ROC_SIGNAL_POOL_SIZE_PROFILE and update default value #71

Closed preda closed 6 months ago

preda commented 6 months ago

The change is two-fold:

The new default of 1000 has this rationale: it allows up to 4 queues to fit within the 4094 events provided by the kernel (with a little margin).

saleelk commented 6 months ago

Thanks for digging this up, I have an internal change that makes #signals not just for profiling but for everything to 64 per queue. That would fix your issue and also addresses the issue in ROCr, I would guess.

preda commented 6 months ago

@saleelk thanks, this is the commit with the change BTW https://github.com/ROCm/clr/commit/c157bfb2022076959c521269b27f34996c1ee730