search

ROCm / composable_kernel

Composable Kernel: Performance Portable Programming Model for Machine Learning Tensor Operators
https://rocm.docs.amd.com/projects/composable_kernel/en/latest/
Other
297 stars 113 forks source link

[-Werror,-Wunused-parameter] Build issue for gfx1100 alone #1357

Closed junliume closed 2 months ago

junliume commented 3 months ago

It's a tiny issue, when we build with gfx1100 only:

CXX=/opt/rocm/bin/amdclang++ cmake -DCMAKE_PREFIX_PATH=/opt/rocm -DCMAKE_BUILD_TYPE=Release -DGPU_TARGETS="gfx1100" -DINSTANCES_ONLY=ON ..

we may see a lot of unused parameter error

error: unused parameter 'c_grid_desc_mblock_mperblock_nblock_nperblock' [-Werror,-Wunused-parameter]

https://github.com/ROCm/composable_kernel/blob/cb13839425e0ec4dfff5b8138104ee3e3183d050/include/ck/tensor_operation/gpu/device/impl/device_grouped_conv_fwd_multiple_abd_xdl_cshuffle_v3.hpp#L116

https://github.com/ROCm/composable_kernel/blob/cb13839425e0ec4dfff5b8138104ee3e3183d050/include/ck/tensor_operation/gpu/device/impl/device_grouped_conv_fwd_multiple_abd_xdl_cshuffle_v3.hpp#L182

It could be very straightforward to fix, we can assign it as "good for first timers" :)