search

ROCm / hcc

HCC is an Open Source, Optimizing C++ Compiler for Heterogeneous Compute currently for the ROCm GPU Computing Platform
https://github.com/RadeonOpenCompute/hcc/wiki
Other
429 stars 107 forks source link

add accelerator_view::create_marker(hsa_barrier_and_packet_t) #1420

Closed jeffdaily closed 4 years ago

jeffdaily commented 4 years ago

Similar to how hc::accelerator_view::dispatch_hsa_kernel allows the caller to pass their own hsa_kernel_dispatch_packet_t, add a new function accelerator_view::create_marker(hsa_barrier_and_packet_t). It behaves nearly identically to accelerator_view::create_marker(hc::memory_scope), but now the caller can specify a nearly complete aql packet. This could be used to indicate both acq and rel scope as well as an associated hsa signal with a non-default starting value.

jeffdaily commented 4 years ago

@scchan I don't think we need this PR now, since we found a solution in HIP that doesn't need this new HCC API. Pending more testing.

jeffdaily commented 4 years ago

Closing this PR. This change is no longer needed. We can revisit at a later time if the need comes up again.