search

ROCm / hipBLASLt

hipBLASLt is a library that provides general matrix-matrix operations with a flexible API and extends functionalities beyond a traditional BLAS library
https://rocm.docs.amd.com/projects/hipBLASLt/en/latest/index.html
MIT License
49 stars 80 forks source link

fix incorrect calcLdsNumBytes calculation #864

Closed aazz44ss closed 3 months ago

aazz44ss commented 3 months ago

fix incorrect ldsPad value in calcLdsNumBytes

hcman2 commented 3 months ago

CI Failed. mci/precheckin/test/gfx90a(main) — Failed in Test stage on gfx90a

aazz44ss commented 3 months ago

CI Failed. mci/precheckin/test/gfx90a(main) — Failed in Test stage on gfx90a

Re-run CI again, it passed.

hcman2 commented 3 months ago

Should we add a test yaml to cover this bug?

aazz44ss commented 3 months ago

Should we add a test yaml to cover this bug?

I just re-ran CI and it passed. Not sure what happened.

hcman2 commented 3 months ago

Not sure which bug this change fixed? if we have bug before this change, the test yaml in this codebase cannot hit the bug this change fixed. That is why I ask for a test yaml to hit this bug.

aazz44ss commented 3 months ago

Not sure which bug this change fixed? if we have bug before this change, the test yaml in this codebase cannot hit the bug this change fixed. That is why I ask for a test yaml to hit this bug.

OK, I misunderstood I thought you were saying CI failed bug, that's what I an not sure, I re-ran CI and it passed, I also check CI on my local gfx942 and passed.

This PR fix wrong value used in the function, not able to reproduce after fix.