search

ROCm / hipCollections

Header-only library of GPU-accelerated, concurrent data structures.
Apache License 2.0
10 stars 0 forks source link

[Issue]: Wavefront size is hard coded to 64 #4

Open mcordery opened 3 months ago

mcordery commented 3 months ago

Problem Description

Currently the wavefront size in hipco is hardcoded to 64 which impacts the ability of being able to supply the rocGraph library for any architectures with a different wavefront size (e.g. 32)

Operating System

Ubunto 22.04.3 LTS

CPU

AMD

GPU

AMD Radeon RX 7900 XT

ROCm Version

ROCm 6.1.0

ROCm Component

No response

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

psamfass commented 1 month ago

@mcordery : Please check if this issue is addressed with the most recent version of hipCo.

mcordery commented 1 month ago

[AMD Official Use Only - AMD Internal Distribution Only]

Philipp, Looks like it does the right thing. We’ll test it out. Just a suggestion you can ignore, you might change something like ‘outer_invoke’ to ‘dispatch’. That way you call a dispatch function and it calls the appropriate 32 or 64 warp size. Anyway, thanks for that we appreciate it. We’re discovering a lot of what we’re dealing with at this point is potentially issues with warp sizes being hard coded.

Matthew J Cordery, PhD Principal Member of Technical Staff AI Group

From: Philipp Samfass @.> Sent: Tuesday, October 8, 2024 7:43 AM To: ROCm/hipCollections @.> Cc: Cordery, Matthew @.>; Mention @.> Subject: Re: [ROCm/hipCollections] [Issue]: Wavefront size is hard coded to 64 (Issue #4)

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.

@mcorderyhttps://github.com/mcordery : Please check if this issue is addressed with the most recent version of hipCo.

— Reply to this email directly, view it on GitHubhttps://github.com/ROCm/hipCollections/issues/4#issuecomment-2399887819, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEJ5XWO3X25BDU3HYGKGF33Z2POO3AVCNFSM6AAAAABMQXNQZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJZHA4DOOBRHE. You are receiving this because you were mentioned.Message ID: @.**@.>>