search

ROCm / hipSOLVER

ROCm SOLVER marshalling library
https://rocm.docs.amd.com/projects/hipSOLVER/en/latest/
MIT License
22 stars 21 forks source link

Build system improvements #259

Open tfalders opened 1 month ago

tfalders commented 1 month ago

This PR brings hipSOLVER's build system more in line with hipBLAS's.

Although it would be nice to get it in for the next release, it's not essential. Don't feel pressured to review it for tomorrow.

tfalders commented 1 month ago

The update to use config-mode search for the NVIDIA backend is an important build system change and we should keep it tightly focused so that it can be easily reverted. I know the inconsistent formatting drives you nuts, but we should keep those sorts of changes separate.

Yeah, I was going to focus on the build changes only, but then I got carried away after reformatting the pieces I borrowed from hipBLAS. Since all the changes (other than formatting) are based on something I saw in hipBLAS, any objections you have to changes in this PR suggest that we might want to propose tweaks to hipBLAS's build system to bring it more in line with hipSOLVER's.