Open littlewu2508 opened 2 years ago
5.0.2 has the same problem. The gziped diff is: hip_prof_str_diff.gz
Updates: in version 5.1.3, I encountered another issue as well as this one.
Running
python /ext4-disk/build/portage/dev-util/hip-5.1.3/work/hipamd-rocm-5.1.3/src/hip_prof_gen.py -v -t --priv /ext4-disk/build/portage/dev-util/hip-5.1.3/work/HIP-rocm-5.1.3/include/hip/hip_runtime_api.h /ext4-disk/build/portage/dev-util/hip-5.1.3/work/hipamd-rocm-5.1.3/src /ext4-disk/build/portage/dev-util/hip-5.1.3/work/hipamd-rocm-5.1.3/include/hip/amd_detail/hip_prof_str.h /ext4-disk/build/portage/dev-util/hip-5.1.3/work/hipamd-rocm-5.1.3_build/include/hip/amd_detail/hip_prof_str.h
I got fatal error:
init name mismatch: 'hipDestroySurfaceObject' <> 'ihipDestroySurfaceObject', file '/ext4-disk/build/portage/dev-util/hip-5.1.3/work/hipamd-rocm-5.1.3/src/hip_surface.cpp', line (83)
I backported 4168c6ded4e54602f6fad8b0a483b20ab7f83cd5 which fix that. Then I got
bad args: args_str: 'hipGraphicsResource** resource,GLuint image,GLtarget,unsigned int flags' arg_pair: 'GLtarget', file '/ext4-disk/build/portage/dev-util/hip-5.1.3/work/hipamd-rocm-5.1.3/src/hip_gl.cpp', line (218)
So I backported part of fb5a64025bb0e10173a1ee4f3475db322b74b594 :
diff --git a/src/hip_prof_gen.py b/src/hip_prof_gen.py
index bd32d5bf..a3071a75 100755
--- a/src/hip_prof_gen.py
+++ b/src/hip_prof_gen.py
@@ -81,7 +81,7 @@ def filtr_api_args(args_str):
args_str = re.sub(r'\s*,\s*', r',', args_str);
args_str = re.sub(r'\s+', r' ', args_str);
args_str = re.sub(r'\s*(\*+)\s*', r'\1 ', args_str);
- args_str = re.sub(r'(enum|struct) ', '', args_str);
+ args_str = re.sub(r'(\benum|struct) ', '', args_str);
return args_str
# Normalizing types
@@ -129,7 +129,9 @@ def pointer_ck(arg_type):
m = re.match(r'(.*)\*$', arg_type)
if m:
ptr_type = m.group(1)
- ptr_type = re.sub(r'const ', '', ptr_type)
+ n = re.match(r'(.*)\*\*$', arg_type)
+ if not n:
+ ptr_type = re.sub(r'const ', '', ptr_type)
if ptr_type == 'void': ptr_type = ''
return ptr_type
#############################################################
@@ -613,7 +615,7 @@ if (len(sys.argv) < 4):
" -p - HIP_INIT_API macro patching mode\n" +
"\n" +
" Example:\n" +
- " $ " + sys.argv[0] + " -v -p -t --priv ./include/hip/amd_detail/hip_runtime_api.h" +
+ " $ " + sys.argv[0] + " -v -p -t --priv ../hip/include/hip/hip_runtime_api.h" +
" ./src ./include/hip/amd_detail/hip_prof_str.h ./include/hip/amd_detail/hip_prof_str.h.new");
# API header file given as an argument
--
2.34.1
And then comes to the same error: "/ext4-disk/build/portage/dev-util/hip-5.1.3/work/hipamd-rocm-5.1.3/include/hip/amd_detail/hip_prof_str.h" needs to be re-generated and checked-in with the current changes
And the diff of hip_prof_str.h is: hip_prof_str_diff.gz
I try to build hip-5.0.1 with profile
USE_PROF_API=1
, but while buildinghip_prof_gen.py
threw"Warning: "/ext4-disk/build/portage/dev-util/hip-5.0.1/work/hipamd-rocm-5.0.1/include/hip/amd_detail/hip_prof_str.h" needs to be re-generated and checked-in with the current changes"
and exit with return code 1. I found that the hip_prof_str.h in src and build dir is different: