search

ROCm / hipamd

35 stars 37 forks source link

RPATH is not optional #22

Open Mystro256 opened 2 years ago

Mystro256 commented 2 years ago

I noticed in 5.1.0, RPATH is not optional.

The commit in question is 58193bf238b290cd05980e0fffa2c56f8a3a3730

While I understand the rational from a ROCm packaging perspective, this causes issues for distros trying to package since RPATH is not optional.

Does this make sense to wrap this within the ROCM_RPATH condition later in the file?

awehrfritz commented 2 years ago

Has there been any progress on resolving this issue?

The latest release version still runs into rpath problems due to the above commit. @agunashe what was the reason for adding those lines and can you come up with a proper solution to this issue?

Mystro256 commented 1 year ago

Hi @awehrfritz there's been some progress. A lot of the RPATH logic should be cleaned up for approximately the ROCm 5.5 release. It might make it into the next planned major release (5.4), but I'm not sure.