search

ROCm / hipamd

35 stars 37 forks source link

Fix inconsistent overrides #63

Open aaronmondal opened 1 year ago

aaronmondal commented 1 year ago

This caused -Winconsistent-missing-override to complain with Clang 17.

aaronmondal commented 1 year ago

If these are not supposed to be overridden by anything else we could also make them final. This could improve performance. See https://devblogs.microsoft.com/cppblog/the-performance-benefits-of-final-classes/ for an explanation.