search

ROCm / hipfort

Fortran interfaces for ROCm libraries
https://rocm.docs.amd.com/projects/hipfort/en/latest/
Other
68 stars 37 forks source link

Bugfix/nvidia platform #57

Closed fluidnumerics-joe closed 1 year ago

fluidnumerics-joe commented 3 years ago

This pull request is needed to make 4.1.x releases of hipfort compatible with hipcc that ships with ROCm 4.1.0 Specifically, hipcc on ROCm 4.1.0 uses HIP_PLATFORM=amd and HIP_PLATFORM=nvidia, as opposed to HIP_PLATFORM=hcc and HIP_PLATFORM=nvcc

gregrodgers commented 2 years ago

Joe, this open PR is old. Do we still need this?

Greg

cgmb commented 1 year ago

Joe, this open PR is old. Do we still need this?

It seems this problem has been fixed in hipfc, but there's a few places in hipfort where it has not (makefile, readme). We're still getting things like the CI set up, but once that infrastructure is in place, I'll make the necessary changes.

Thanks for the heads up, Joe! Apologies on the slow review process. We will try to improve upon that going forward.