search

ROCm / llvm-project

This is the AMD-maintained fork of the LLVM git repository. This repository accepts pull requests and issues related to AMD fork-specific topics (amd/*). For all other issues/PRs, please submit upstream at https://github.com/llvm/llvm-project.
Other
94 stars 48 forks source link

Find CLANG_RESOURCE_DIR using clang -print-resource-dir #70

Open littlewu2508 opened 1 month ago

littlewu2508 commented 1 month ago

Continuation of https://github.com/ROCm/ROCm-CompilerSupport/pull/51

lamb-j commented 1 month ago

Thanks for adding!

Testing this with internal CI, will report back with results

lamb-j commented 1 week ago

Getting this error on Windows:

2024-05-15 19:53:35 FAILED: tools/comgr/opencl1.2-c.pch C:/mlse/drivers/compute/build/native/Release/x64/lc/tools/comgr/opencl1.2-c.pch 2024-05-15 19:53:35 cmd.exe /C "cd /D C:\mlse\drivers\compute\build\native\Release\x64\lc\tools\comgr && C:\mlse\drivers\compute\build\native\Release\x64\lc\bin\clang.exe -cc1 -x cl-header -triple amdgcn-amd-amdhsa -Werror -O3 -Dcl_khr_fp64 -Dcl_khr_fp16 -DNDEBUG -cl-std=CL1.2 -emit-pch -o C:/mlse/drivers/compute/build/native/Release/x64/lc/tools/comgr/opencl1.2-c.pch <"2024-05-15 19:53:35 The syntax of the command is incorrect.

Apparently "The syntax of the command is incorrect" is a Windows error on invalid file copy/move/rename. So I'm guessing either CLANG_RESOURCE_DIR or OPENCL_C_H are empty?

Any ideas? Should we condition this on NOT WIN32? Also wondering if we may want to keep some of the error checking

lamb-j commented 1 week ago

FYI I did land this internally, but then had to revert due to the error above, so we can keep using this PR to discuss

https://github.com/ROCm/llvm-project/commit/a992a6a5617d41efb86b4fb9c09b400856f35721 - [Comgr] Find CLANG_RESOURCE_DIR using clang -print-resource-dir https://github.com/ROCm/llvm-project/commit/3b543c26d226e97cafc1199a376a2e8773f7e1d6 - Revert "[Comgr] Find CLANG_RESOURCE_DIR using clang -print-resource-dir"