ROCm / omnitrace

Omnitrace: Application Profiling, Tracing, and Analysis
https://rocm.docs.amd.com/projects/omnitrace/en/latest/
MIT License
297 stars 27 forks source link

Flush stdout when listing keys + bump verbose level for GPU count #346

Closed ajanicijamd closed 4 months ago

ajanicijamd commented 4 months ago
ajanicijamd commented 4 months ago

This is a fix for the failing test in SWDEV-466924: test omnitrace-avail-list-keys, which runs command omnitrace-avail --list-keys --expand-keys is failing because the command writes some output to stdout and some to stderr, and ctest redirects them both to the same file, where they get mixed, so the strings that the test is supposed to find ((.)%argv%(.)%argv_hash%) is broken in the log file. The fix is to write everything to stdout.

jrmadsen commented 4 months ago

Additionally

https://github.com/ROCm/omnitrace/blob/f0bd9126a5456eb9e511d13261af262d17d9b61b/source/bin/omnitrace-avail/avail.cpp#L524

and

https://github.com/ROCm/omnitrace/blob/f0bd9126a5456eb9e511d13261af262d17d9b61b/source/bin/omnitrace-avail/avail.cpp#L529

can be bumped to level 1 or 2.

ajanicijamd commented 4 months ago

I made those changes. Bumped the logging level to 1 for those two calls of verbprintf.