Test and Enable OMNITRACE_BUILD_DYNINST, if needed

ROCm / omnitrace

Omnitrace: Application Profiling, Tracing, and Analysis

https://rocm.docs.amd.com/projects/omnitrace/en/latest/

MIT License

301 stars 27 forks source link

Test and Enable OMNITRACE_BUILD_DYNINST, if needed #380

Closed dgaliffiAMD closed 2 months ago

dgaliffiAMD commented 2 months ago

Test find_package(Dyninst) and if it is not found, then enable OMNITRACE_BUILD_DYNINST and DYNINSTBUILD{TBB,BOOST,ELFUTILS,LIBIBERTY}.

jrmadsen commented 2 months ago

I know this seems like a good idea but it isn’t. I used to deploy this strategy and it becomes really problematic when you have an external package installed and CMake isn’t finding it (or one of the external deps) for some reason. I’d highly advise against it.