search

ROCm / rocDecode

rocDecode is a high performance video decode SDK for AMD hardware
https://rocm.docs.amd.com/projects/rocDecode/en/latest
Other
10 stars 14 forks source link

Bug Fix - crop needs to be set using target width and height #370

Closed LakshmiKumar23 closed 3 months ago

LakshmiKumar23 commented 3 months ago

Fixes a seg fault observed when using crop parameters for video decode reported by @paveltc. Tested with cropping middle of the image, start and towards the end. Requires this change since we now have disp_height/disp_width and target_height/target_width separate

jeffqjiangNew commented 3 months ago

@LakshmiKumar23 Do AVC and HEVC conformance tests pass with this PR?

LakshmiKumar23 commented 3 months ago

@jeffqjiangNew I did not run conformance. Did you mean to close this PR?

jeffqjiangNew commented 3 months ago

@LakshmiKumar23 A good practice before pushing changes to rcoDecode is to run AVC and HEVC conformance tests and make sure they pass. Particularly in this PR, we modify output surface info and chroma height, which may (or may not) impact how we output decoded images when user cropping is not set.

LakshmiKumar23 commented 3 months ago

@jeffqjiangNew @rrawther ran conformance with this branch. All 135 streams are passing

Conformance test completed on the 135 streams:
     - The number of passing streams is 135
     - The number of failing streams is 0
     - The number of streams that did not finish decoding is 0
jeffqjiangNew commented 3 months ago

Can you also test AVC conformance streams as well?

LakshmiKumar23 commented 3 months ago

@jeffqjiangNew you closed the PR again haha

jeffqjiangNew commented 3 months ago

@LakshmiKumar23 Sorry I probably clicked the wrong button. My bad. :)

LakshmiKumar23 commented 3 months ago

Can you also test AVC conformance streams as well?

AVC passes too, all 127 streams


Conformance test completed on the 127 streams:
     - The number of passing streams is 127
     - The number of failing streams is 0
     - The number of streams that did not finish decoding is 0
LakshmiKumar23 commented 3 months ago

@paveltc can you run some other tests on this PR too?