device: uint32_t -> __hip_uint32_t, int32_t -> __hip_int32_t

ROCm / rocFFT

Next generation FFT implementation for ROCm

https://rocm.docs.amd.com/projects/rocFFT/en/latest/

Other

175 stars 84 forks source link

device: uint32_t -> __hip_uint32_t, int32_t -> __hip_int32_t #446

Closed evetsso closed 10 months ago

evetsso commented 11 months ago

The undecorated type names are deprecated in hipRTC.

evetsso commented 11 months ago

Does this block run our code on NV cards?

It's certainly not helping. The typedefs are being removed because they're not supposed to be there, and that was breaking some users that were defining their own equivalents. So with this change, we're more compatible with NV.

ROCmMathLibrariesBot commented 10 months ago

Performance reports: Commit hashes: b9926b55ee877db3d901e364135c8341b623c3cd gfx90a single report gfx90a double report

evetsso commented 10 months ago

Type removal in hipRTC didn't end up happening in 6.0. Closing.