search

ROCm / rocMLIR

128 stars 40 forks source link

use removeUpperDims if possible #1607

Closed dhernandez0 closed 2 months ago

dhernandez0 commented 2 months ago

In this PR we use "removeUpperDims" utility function wherever possible to clean up thread layout view creation functions.

There are some cases where it's not possible due to this bug: https://github.com/ROCm/rocMLIR-internal/issues/1562

ticket: https://github.com/ROCm/rocMLIR-internal/issues/1529

manupak commented 2 months ago

There are some cases where it's not possible due to this bug: https://github.com/ROCm/rocMLIR-internal/issues/1562

Can we add comments in the code where this blocks from doing the change ? Also in the DoD of the ticket 1562, please link the locations of the code that needs to be changed as part of 1562

dhernandez0 commented 2 months ago

There are some cases where it's not possible due to this bug: ROCm/rocMLIR-internal#1562

Can we add comments in the code where this blocks from doing the change ? Also in the DoD of the ticket 1562, please link the locations of the code that needs to be changed as part of 1562

done