search

ROCm / rocMLIR

124 stars 40 forks source link

[DO NOT SQUASH] Fp8 support for gfx12 #1612

Closed giuseros closed 3 weeks ago

giuseros commented 1 month ago

This PR adds support for fp8 in rocMLIR. As per usual, I split the PR in two:

Given the status of our CI, I was not able to run a full set of tests, but I tried a couple of examples, and it looked like it was working. We are trying to fix this, but can I have a first round of reviews to see if those changes are reasonable?

giuseros commented 1 month ago

Please leave a big shouty comment on the gfx12 info saying that this isn't accurate and needs to be adjusted after hardware release

I am not sure I understand where the bit shouty comment should go :)

krzysz00 commented 1 month ago

Sorry, in AmdArchDb on our side - it could do with a reminded that, say, numCUs isn't right

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 42.10526% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.71%. Comparing base (26c8d17) to head (ec51887). Report is 5 commits behind head on develop.

Files Patch % Lines
mlir/lib/Dialect/Rock/IR/RockDialect.cpp 41.66% 6 Missing and 1 partial :warning:
mlir/lib/Dialect/Rock/IR/WmmaInsnGroup.cpp 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1612 +/- ## =========================================== + Coverage 77.67% 77.71% +0.04% =========================================== Files 95 95 Lines 25782 25794 +12 Branches 3637 3641 +4 =========================================== + Hits 20026 20046 +20 + Misses 4284 4280 -4 + Partials 1472 1468 -4 ``` | [Flag](https://app.codecov.io/gh/ROCm/rocMLIR/pull/1612/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ROCm) | Coverage Δ | | |---|---|---| | [mfma](https://app.codecov.io/gh/ROCm/rocMLIR/pull/1612/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ROCm) | `77.71% <42.10%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ROCm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.