ROCm / rocMLIR

124 stars 40 forks source link

Handle process exception from calling rocminfo, to see why it sometimes fails. #1628

Closed pcf000 closed 3 weeks ago

pcf000 commented 3 weeks ago

Sometimes we see rocminfo CalledProcessErrors in the log file, but it doesn't capture stderr and it's not apparent why it failed. This patch attempts to catch the error and print stderr so hopefully we'll see it and maybe can do something about it.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.80%. Comparing base (9ef8698) to head (35c9878). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1628 +/- ## =========================================== - Coverage 78.07% 77.80% -0.27% =========================================== Files 98 98 Lines 26252 26252 Branches 3731 3731 =========================================== - Hits 20495 20425 -70 - Misses 4291 4328 +37 - Partials 1466 1499 +33 ``` | [Flag](https://app.codecov.io/gh/ROCm/rocMLIR/pull/1628/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ROCm) | Coverage Δ | | |---|---|---| | [mfma](https://app.codecov.io/gh/ROCm/rocMLIR/pull/1628/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ROCm) | `77.80% <ø> (-0.27%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ROCm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.