search

ROCm / rocMLIR

128 stars 40 forks source link

Fix: Correctly lower FP8 instructions for specific architectures. #1638

Closed stefankoncarevic closed 2 months ago

stefankoncarevic commented 2 months ago

Ensure that the FP8 conversion instructions are correctly identified and lowered with architectures that support FP8 instructions.

stefankoncarevic commented 2 months ago

This fix this issue https://github.com/ROCm/rocMLIR-internal/issues/1591

manupak commented 2 months ago

Im confused now... how is this different from https://github.com/ROCm/rocMLIR/pull/1637?

stefankoncarevic commented 2 months ago

You're right, I didn't see that it was already corrected in PR. I will close it, my bad.