search

ROCm / rocMLIR

128 stars 40 forks source link

Use cmake -E touch for cross-platform compatibility #1644

Closed stefankoncarevic closed 1 month ago

stefankoncarevic commented 1 month ago

This PR replaces the platform-specific touch command with cmake -E touch to ensure compatibility across different operating systems. The cmake -E touch command works on both Windows and Linux, eliminating the need for conditional branches in the CMake script.

stefankoncarevic commented 1 month ago

I believe this change will help improve cross-platform compatibility by using cmake -E touch instead of platform-specific commands. This should simplify the CMake script and ensure consistent behavior across different operating systems. https://github.com/ROCm/rocMLIR-internal/issues/1609

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.67%. Comparing base (c9e737f) to head (68bdc50). Report is 3 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1644 +/- ## =========================================== + Coverage 78.02% 83.67% +5.64% =========================================== Files 98 98 Lines 26316 26316 Branches 3766 3766 =========================================== + Hits 20533 22019 +1486 + Misses 4281 4263 -18 + Partials 1502 34 -1468 ``` | [Flag](https://app.codecov.io/gh/ROCm/rocMLIR/pull/1644/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ROCm) | Coverage Δ | | |---|---|---| | [mfma](https://app.codecov.io/gh/ROCm/rocMLIR/pull/1644/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ROCm) | `83.67% <ø> (+5.64%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ROCm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.