ROCm / rocm-cmake

CMake modules used within the ROCm libraries
https://rocm.docs.amd.com/projects/ROCmCMakeBuildTools/en/latest/
MIT License
62 stars 43 forks source link

Add codeowners for documentation #168

Closed samjwu closed 9 months ago

samjwu commented 10 months ago

Relates to https://github.com/ROCm/ROCm/issues/2832 Adding documentation team as codeowners for documentation. Goal is to make this group of code owners reviewers when merging documentation changes.

Please note that this requires the team to be added as a role with Write permissions.

samjwu commented 10 months ago

Please remove the executable permissions from the codeowners file.

Fixed in latest.

Also, would someone with admin permissions to this repo be able to add the ROCm Documentation team with write permissions? GitHub flags the additions to the CODEOWNER file as an error otherwise. Thanks!

eidenyoshida commented 10 months ago

@samjwu I added the docs team with write privilege

can you also add the original code owners to all the docs files?