search

ROCm / rocm_smi_lib

ROCm SMI LIB
https://rocm.docs.amd.com/projects/rocm_smi_lib/en/latest/
MIT License
116 stars 49 forks source link

`memcpy` not found -- missing `string.h` #106

Closed tpkessler closed 10 months ago

tpkessler commented 2 years ago

When compiling rocm_smi_lib with GCC 12 errors like

/build/rocm-smi-lib/src/rocm_smi_lib-rocm-5.1.1/src/rocm_smi_gpu_metrics.cc:225:11: error: ‘memset’ was not declared in this scope
  225 |     (void)memset(data->temperature_hbm, 0,
      |           ^~~~~~

or

/build/rocm-smi-lib/src/rocm_smi_lib-rocm-5.1.1/src/rocm_smi_gpu_metrics.cc: In function ‘void map_gpu_metrics_1_2_to_rsmi_gpu_metrics_t(const rsmi_gpu_metrics_v_1_2*, rsmi_gpu_metrics_t*)’:
/build/rocm-smi-lib/src/rocm_smi_lib-rocm-5.1.1/src/rocm_smi_gpu_metrics.cc:242:5: error: ‘memcpy’ was not declared in this scope
  242 |     memcpy(rsmi_gpu_metrics, &gpu_metrics_v_1_2->base,
      |     ^~~~~~

appear. Adding string.h to the includes of this file fixes the isssue, see my PR.

dmitrii-galantsev commented 10 months ago

Fixed in https://github.com/RadeonOpenCompute/rocm_smi_lib/commit/99034af009ab141163c83a817d6ac8380370760d