ROCm / rocm_smi_lib

ROCm SMI LIB
https://rocm.docs.amd.com/projects/rocm_smi_lib/en/latest/
MIT License
116 stars 49 forks source link

typo in rocm smi lib 5.7.0 #130

Closed emollier closed 11 months ago

emollier commented 1 year ago

Hi, while working on the Debian package upgrade to ROCm 5.7.0, our linter lintian caught a typo. I was going to open a merge request, but the rocm-5.7.0 branch doesn't seem to have made it to main trunk of the VCS yet, so I'm providing the patch in an issue instead.

--- rocm-smi-lib.orig/src/rocm_smi_logger.cc
+++ rocm-smi-lib/src/rocm_smi_logger.cc
@@ -117,7 +117,7 @@
   if(!m_File.is_open()) {
     initialize_resources();
     if (!m_File.is_open()) {
-      std::cout << "WARNING: re-initializing resources was unsuccessfull."
+      std::cout << "WARNING: re-initializing resources was unsuccessful."
                 <<" Unable to print the following message." << std::endl;
       logOnConsole(data);
       unlock();
@@ -261,7 +261,7 @@
     if(!m_File.is_open()) {
       initialize_resources();
       if (!m_File.is_open()) {
-        std::cout << "WARNING: re-initializing resources was unsuccessfull."
+        std::cout << "WARNING: re-initializing resources was unsuccessful."
                   <<" Unable to print the following message." << std::endl;
         std::string txtStr(text);
         std::cout << txtStr << std::endl;
dmitrii-galantsev commented 1 year ago

Sweet! Looks like I caught it about a month ago, but those changes didn't make it to 5.7.0. We're working on creating a develop branch to keep internal changes synced to github. I'll keep the issue open until it's public :)

dmitrii-galantsev commented 11 months ago

fixed in 4aef7675