search

ROCm / rocm_smi_lib

ROCm SMI LIB
https://rocm.docs.amd.com/projects/rocm_smi_lib/en/latest/
MIT License
111 stars 48 forks source link

The returned rsmi_status_t is inconsistent #146

Open effective-qdd opened 6 months ago

effective-qdd commented 6 months ago

rocm_smi_lib/src/rocm_smi.cc

In function rsmi_event_notification_mask_set

if (dev->evt_notif_anon_fd() == -1) {
    return RSMI_INITIALIZATION_ERROR;
  }

And in function rsmi_event_notification_stop(uint32_t dv_ind)

if (dev->evt_notif_anon_fd() == -1) {
    return RSMI_STATUS_INVALID_ARGS;
  }

Should the returned status also be RSMI_INITIALIZATION_ERROR in rsmi_event_notification_stop? I'm a little confused when I get RSMI_INITIALIZATION_ERROR because there is only one param (uint32_t dv_ind) in the function.