search

ROCm / rocm_smi_lib

ROCm SMI LIB
https://rocm.docs.amd.com/projects/rocm_smi_lib/en/latest/
MIT License
111 stars 48 forks source link

change CMAKE_HOST_SYSTEM_PROCESSOR to CMAKE_SYSTEM_PROCESSOR #158

Closed Calandracas606 closed 2 months ago

Calandracas606 commented 4 months ago

Fixes build failure when cross compiling.

This should be CMAKE_SYSTEM_PROCESSOR, which will default to CMAKE_HOST_SYSTEM_PROCESSOR when not cross compiling

https://cmake.org/cmake/help/latest/variable/CMAKE_SYSTEM_PROCESSOR.html https://cmake.org/cmake/help/latest/variable/CMAKE_HOST_SYSTEM_PROCESSOR.html

Tested cross compiling to aarch64, armv6l, and armv7l (although its extremely unlikely that 32-bit arm will ever use this library)

dmitrii-galantsev commented 3 months ago

Thank you! I'm submitting the change internally. It should make it to github in a couple days.

dmitrii-galantsev commented 2 months ago

Merged in https://github.com/ROCm/rocm_smi_lib/commit/38d1275d64f06800f3cf46ce198c4ab0cd6bbf42