search

ROCm / rocm_smi_lib

ROCm SMI LIB
https://rocm.docs.amd.com/projects/rocm_smi_lib/en/latest/
MIT License
111 stars 48 forks source link

Fix issue: 162 (typo) #163

Closed PTFOPlayer closed 2 months ago

PTFOPlayer commented 3 months ago

Fix for issue: https://github.com/ROCm/rocm_smi_lib/issues/162

There is a difference in argument types between declaration and definition. This made the function unusable.

Files affected:

dmitrii-galantsev commented 3 months ago

great catch! thanks. I'll merge it internally and get pushed out to github shortly.

dmitrii-galantsev commented 3 months ago

also, your work on https://github.com/PTFOPlayer/rocm_smi_lib_rs is exciting!

PTFOPlayer commented 3 months ago

also, your work on https://github.com/PTFOPlayer/rocm_smi_lib_rs is exciting!

Thanks! I'm really glad that whoever created this API noticed my Rust adaptation.

dmitrii-galantsev commented 2 months ago

Accepted in https://github.com/ROCm/rocm_smi_lib/commit/54af22ca614a9349b6a02cfff691501f19365dda