search

ROCm / rocminfo

ROCm Application for Reporting System Info
Other
35 stars 32 forks source link

Added env var to set target.lst #26

Closed justxi closed 4 years ago

justxi commented 5 years ago

Extends the "rocm_agent_enumerator" to read the "target.lst" from a location set by env var "ROCM_TARGET_LST". If not set, it does not change anything, the behaviour is like before.

In the install scripts for Gentoo Linux execution of "rocm_agent_enumerator" respectively "rocminfo" is not allowed, due to a sandbox. Using this env var gives the possibility to adjust the "target.lst" file and store it locally, while installing new ROCm software.

justxi commented 5 years ago

Any comments on this?

whchung commented 5 years ago

@justxi Thanks for the contribution, since this is a new environment variable be introduced, could you also document it? Perhaps amend README.md in this project?

justxi commented 5 years ago

@whchung Yes, added.

justxi commented 5 years ago

Does the patch has a chance to be accepted for ROCm 2.10?

justxi commented 4 years ago

Or the next release of ROCm?

cfreehill commented 4 years ago

Sorry for the delay on this. I didn't notice it was waiting for a review by me.

justxi commented 4 years ago

No problem, thanks.