ROCm / rocprofiler-compute

Advanced Profiling and Analytics for AMD Hardware
https://rocm.docs.amd.com/projects/omniperf/en/latest/
MIT License
135 stars 49 forks source link

Quickstart for grafana could use a simple example #135

Closed skyreflectedinmirrors closed 1 year ago

skyreflectedinmirrors commented 1 year ago

https://github.com/AMDResearch/omniperf/blob/a346db7646b0a935f4cac51d131b4a585f065c05/src/docs/getting_started.md?plain=1#L46

Similar to the other examples in this section, but here we give ~ no detail. At the very least, we should say something like "this requires installation specific connection details, see the Database discussion below for information about how to obtain these"

bcaddy commented 1 year ago

I'd like to second this. I'm an OLCF user trying to use Omniperf and even after reading the documentation I have absolutely no idea what I'm supposed to do to get grafana setup.

coleramos425 commented 1 year ago

Thanks for the suggestion. I've added more details to the Grafana setup and usage sections. Please see those additions and let me know if anything is still unclear.

https://amdresearch.github.io/omniperf/installation.html

bcaddy commented 1 year ago

This looks better. Thank you.